Skip to content

Conversation

@josteink
Copy link

@josteink josteink commented Jul 5, 2022

More details here: GHSA-5crp-9r3c-p9vr

@MarcoRossignoli
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@josteink
Copy link
Author

Uhm. Build still red. Any action needed on my part?

@josteink
Copy link
Author

josteink commented Jul 30, 2022

From the build:

/home/vsts/work/1/s/src/coverlet.console/ConsoleTables/ConsoleTable.cs(1,1): error IDE0073: A source file contains a header that does not match the required text [/home/vsts/work/1/s/src/coverlet.msbuild.tasks/coverlet.msbuild.tasks.csproj]

This is clearly not an error in my pull-request after all? 😄

Edit: It clearly was.

@josteink
Copy link
Author

josteink commented Aug 1, 2022

"Clearly not" ahem

Looking into the errors, and validating on git master, I could see the problem was exclusively present on my branch.

I've fixed 2 nullability-related issues (which was probably always there) in a couple of tests and it builds and tests cleanly on my machine now 😄

@josteink
Copy link
Author

josteink commented Aug 1, 2022

Build now succeeds, but 1 test now fails in CI (while not locally), and I don't have access to view what test failed or how it failed.

Help? :)

@MarcoRossignoli
Copy link
Collaborator

/azp run

@Bertk
Copy link
Collaborator

Bertk commented Aug 24, 2023

PR is obsolete. The version of Newtonsoft.Json was updated with #1510

@Bertk Bertk closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants