ExcludeFromCodeCoverage not working for autogen getters and setters

[pape77]

Noticed that when trying to apply the excludeFromCoverage attribute to getters and setters from a
class property, they are not taken into account

   public class Key
    {
       [ExcludeFromCodeCoverage]
        public int Id { get; set; }

        public Guid Uuid { get; set; }

        public Guid Kid { get; set; }
    }

"/build/src/Keys.Data/Entities/Key.cs": {
      "Keys.Data.Entities.Key": {
        "System.Int32 Keys.Data.Entities.Key::get_Id()": {
          "Lines": {
            "10": 0
          },

This can easily be seen in action in existing tests within coverlet. In InstrumenterTests.cs, in the TestInstrument_ClassesWithExcludeAttributeAreExcluded
Just remove the [ExcludeFromCodeCoverage] attribute from one of the classes that this method uses in Samples.cs and add a property like this Id one.

For example in Samples.cs change this class as follows:

    public class ClassExcludedByCoverletCodeCoverageAttr
    {

        public string Method(string input)
        {
            if(string.IsNullOrEmpty(input))
                throw new ArgumentException("Cannot be empty", nameof(input));

            return input;
        }

        [ExcludeFromCodeCoverage]
        public int Id { get; set; }
    }

Then you will that in method InstrumentType from Instrumenter.cs the attributes don't show up, because the method name is changed to get_Id() (autogenerated) and so it gets instrumented anyway.

Can we fix this somehow?

[pape77]

Similar thing happens with async methods which are read like this (with MoveNext stuff):

"Keys.Data.Repositories.KeyRepository/<FindOrCreateAsync>d__6": {
        "System.Void Keys.Data.Repositories.KeyRepository/<FindOrCreateAsync>d__6::MoveNext()":
"Lines": {
            "55": 2,
            "56": 2,
            "58": 2,
  ...
}
}

and then all attributes are lost when Instrumenter.cs 's method is evauluating

[SlowLogicBoy]

try:

public int MyProperty { [ExcludeFromCodeCoverage] get; [ExcludeFromCodeCoverage] set; }

[consultwithmike]

@SlowLogicBoy that workaround does work, but I'd say we need to get something in place that iterates the Properties collection in the Iterator as well so that we don't have to decorate the get and set, but rather the property itself.

Honestly, I don't even think we'd have to support properties, we could just add the get and set accessors to the methods listing if we see the property is excluded.

[pape77]

Thank's for the hack @SlowLogicBoy
Indeed @consultwithmike that's what I expected to happen.
I'm guessing for the async things, a similar thing happens, cuz they are autogenerated with that name or something.
I looked into the Instrumenter.cs a bit, but got no clear solution for it

[MarcoRossignoli]

@pape77 is this issue still here?

[MarcoRossignoli]

Now we can use p:ExcludeByAttribute=\"CompilerGeneratedAttribute\" to skip autogen prop

[StingyJack]

@SlowLogicBoy @MarcoRossignoli - this is still a problem for properties

Should this issue really be closed?

[MarcoRossignoli]

This issue is old can you open new one?
Which version are you using?

[StingyJack]

I was going to but found that a similar issue was opened after this and was closed as a duplicate of this.