- 
                Notifications
    You must be signed in to change notification settings 
- Fork 11
Add GSI-based vector search implementation #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Summary of ChangesHello @azaddhirajkumar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the demo's capabilities by integrating a GSI-based vector search option, complementing the existing FTS-based approach. The changes provide users with more flexibility in choosing their vector search strategy within Couchbase, along with comprehensive documentation to guide the setup and execution of both methods. Highlights
 Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a GSI-based vector search implementation as an alternative to the existing FTS-based approach. This is a great addition, providing users with two different ways to leverage Couchbase vector search. The changes include a new chat_with_pdf_gsi.py application, updates to the README.md to document both approaches, and configuration adjustments.
My review focuses on improving the code quality and maintainability of the new GSI implementation and ensuring the documentation is clear and accessible. I've suggested refactoring some parts of the new Python script for better readability and adherence to conventions, and pointed out some potentially broken links in the README. Overall, the changes are well-structured and the new documentation is very thorough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor updates & we should be good to go
No description provided.