Skip to content

Conversation

AdityaSripal
Copy link
Member

Updates based on #629

Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// only unordered channels allowed
abortTransactionUnless(order === UNORDERED)
// assert that version is "ics721-1"
abortTransactionUnless(version === "ics721-1")
// or relayer passed in empty version
abortTransactionUnless(version === "ics721-1" || version === "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should communicate with the team implementing the NFT transfer app so that they take into account this change (if they don't already), right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they will have to to compile with latest ibc-go versions. but it would be good to update them regardless

@AdityaSripal AdityaSripal merged commit d42c89d into master Jul 11, 2022
@AdityaSripal AdityaSripal deleted the aditya/update-721-cbs branch July 11, 2022 10:20
@crodriguezvega crodriguezvega mentioned this pull request Aug 15, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants