Enhance support for lang/type attributes #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces support for both `lang=` and `language=` attributes. Note: support for those have been recently added to core packages (e.g. ASP) and will be part of next Vue package. This commit aligns Svelte with those.
Align with Vue and other template syntaxes. Some even preferred only "coffee". Lets support both forms in all of them.
This commit scopes `lang=""` attributes `meta.attribute-with-value.lang` and `type=""` attributes `meta.attribute-with-value.type`, to enable support for language/mime-type value completions. Note: mime-type completions require ST release with following PR merged. related with sublimehq/Packages#4061
This commit removes explicit js/javascript lang-type pattern as it is already handled as default language by `(?=\S)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
lang=andtype=attribute values.language=attribute to align with recent core package changes.lang="coffee"as alternative forlang="coffeescript".