Skip to content

chore(test): cleanup machine on finish #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

chore(test): cleanup machine on finish #3284

merged 2 commits into from
Jul 14, 2025
+3 −1

Conversation

cbr7
Copy link
Contributor

@cbr7 cbr7 commented Jul 10, 2025

What does this PR do?

Cleanups podman machine on the VM before finishing.

What issues does this PR fix or reference?

@cbr7 cbr7 requested review from benoitf, jeffmaury and a team as code owners July 10, 2025 19:12
@cbr7 cbr7 requested review from feloy and gastoner July 10, 2025 19:12
@odockal
Copy link
Contributor

odockal commented Jul 11, 2025 •
edited
Loading

@cbr7 rebase once #3286 is merged. Tests then should pass and we are good to go.

odockal
odockal reviewed Jul 11, 2025
View reviewed changes
Copy link
Contributor

@odockal odockal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ScrewTSW
ScrewTSW approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@ScrewTSW ScrewTSW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbr7 cbr7 merged commit 0bf3f8f into containers:main Jul 14, 2025
7 checks passed
@cbr7 cbr7 deleted the cleanup_podman_machine_on_finish branch July 14, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odockal odockal odockal left review comments

@ScrewTSW ScrewTSW ScrewTSW approved these changes

@benoitf benoitf Awaiting requested review from benoitf benoitf is a code owner

@jeffmaury jeffmaury Awaiting requested review from jeffmaury jeffmaury is a code owner

@feloy feloy Awaiting requested review from feloy feloy is a code owner automatically assigned from containers/podman-desktop-reviewers

@gastoner gastoner Awaiting requested review from gastoner gastoner is a code owner automatically assigned from containers/podman-desktop-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbr7 @odockal @ScrewTSW