Skip to content

Conversation

@hmaarrfk
Copy link

@hmaarrfk hmaarrfk commented May 17, 2025

In my workflow, I change a bit more than just the name depending on the environment being base or not.
This expands the functionality of #180
xref: #207

This provides those switches.

It also provides a way to "not run inside a bash shell"

Let me know if you are interested in this, I need to go through the checklist.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@github-project-automation github-project-automation bot moved this to 🆕 New in 🔎 Review May 17, 2025
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 17, 2025
@hmaarrfk hmaarrfk force-pushed the expand_more_things_as_dict branch from 5114612 to 9514862 Compare May 17, 2025 21:22
@hmaarrfk hmaarrfk force-pushed the expand_more_things_as_dict branch from 9514862 to b36bf87 Compare May 17, 2025 21:23
@jaimergp
Copy link
Contributor

Hm, I'm not sure about this. The is_base bits were implemented to maintain feature parity with menuinst 1.x, but I was never a fan. Assuming you control the installer generation via constructor, if you need different commands per environment, can that be achieved with two different packages: shortcut-for-app and shortcut-for-app-in-base?

@hmaarrfk
Copy link
Author

Your suggestion would work, and it isn’t a bad one. I might just do it.

The problem is that any application will have duplicate their menuinst packages. That’s fine for me. But will generate future annoyance for users.

I’ll try and see how it looks.

Thanks again for the reviews!

@jaimergp
Copy link
Contributor

jaimergp commented Jul 7, 2025

In the future, base is going to be a protected environment and apps will be recommended to ship a "default" env with their software, leaving conda in base (and nothing else), as drafted in conda-forge/miniforge#740. I anticipate those keys to be increasingly infrequent 🤞

@hmaarrfk
Copy link
Author

hmaarrfk commented Jul 7, 2025

But in my use case, my main app is « my application » and not conda. I want my base to be protected too ;)

this is less for miniforge, more for customized use cases.

@jaimergp
Copy link
Contributor

jaimergp commented Jul 7, 2025

Fair enough. Also, I think you could accomplish the same with a single package, but two build variants, with some sed replacement similar to what we do in the napari shortcut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

3 participants