feat(volume): Enhance volume parsing to support variable default values #830
+260
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suleiman Dibirov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where
docker compose config --no-interpolateincorrectly parsed volume specifications containing variables with default values (e.g.,${VAR:-DEFAULT}). The parser was treating colons inside variable substitutions as volume spec separators, causing paths to be truncated at the :- delimiter.The fix adds tracking for
${...}substitution blocks to ensure colons are only treated as separators when outside of variable expressions. This correctly handles complex cases including multiple colons in defaults (${TIME:-12:30:45}), nested braces, and variables in both source and target paths.docker/compose#13327