Skip to content

Conversation

kendalharland
Copy link
Contributor

@kendalharland kendalharland commented Jun 11, 2024

See hendrikmuhs/ccache-action#204. This is necessary for this workflow to run on custom runners where $USERPROFILE/.cargo/bin/ or any future installation path isn't already part of $GITHUB_PATH

@compnerd
Copy link
Owner

I think that we should wait a bit and see if upstream responds. IIRC, they were pretty responsive, so giving them 24-48h seems reasonable.

@kendalharland kendalharland force-pushed the kendal/pin-ccache-action branch from e726690 to 48fc1e9 Compare June 12, 2024 15:57
@kendalharland
Copy link
Contributor Author

I think that we should wait a bit and see if upstream responds. IIRC, they were pretty responsive, so giving them 24-48h seems reasonable.

I think this is reasonable. At the same time, waiting for upstream reviews from someone I can't directly contact, who also has their own priorities outside the project creates an undesirable slow down :/ I wonder if there is a less distributed strategy for managing changes to the 3p actions we depend on, such as keeping our own forks that are auto-synced, and retroactively upstreaming all changes when possible.

@kendalharland
Copy link
Contributor Author

kendalharland commented Jun 13, 2024

@compnerd let's merge! Seems like upstream is not attending the PR at the moment. You'll have to do it since I don't have permission

@kendalharland
Copy link
Contributor Author

Upstream has merged the change and this is no longer needed. I'll send a separate PR to revert back to hendrikmuhs/ccache-action

@kendalharland kendalharland deleted the kendal/pin-ccache-action branch June 28, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants