Ci updates #18
Merged
Ci updates #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoerdsimons
force-pushed
the
ci-updates
branch
from
8811a4a to
c216a90
Compare
Our current clippy CI runs only ran on the default target, which meant test code didn't get clippy tested. Fix the warnings in the test code to allow enabling clippy in CI on them
Don't try to push the docker container on a PR as that will fail for PRs that aren't from project members
To make it it easier to enable gitlab merge queues add a final allgreen job in the CI workflow to key success on
actions-rs is no longer maintained, switch over to dtolnay/rust-toolchain instead which is. While there also ensure the various checks also check all targets/features as applicable For the rust toolchain aim for a specific version so CI doesn't start failing over time. For the version also aim for the version of rustc in debian unstable to ensure things can build with that version of the compiler
To allow catching newer clippy lints also run clippy from the latest stable rust toolchain. This check is allowed to fail so CI doesn't start failing due to newer lints being introduced.
Check the build still works when actually using the (direct) minimal dependencies. For now this needs a nightly rust
actions/checkout@v2 is using an outdated version of node; bump to v4 which is the latest version
sjoerdsimons
force-pushed
the
ci-updates
branch
from
c216a90 to
870505c
Compare
For merge queue's to work the CI has to run on the `merge_group` event. Also ignore pushes to the merge queue branches to avoid running CI twice
sjoerdsimons
force-pushed
the
ci-updates
branch
from
5fae108 to
bcac17e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
various CI updates; main updates: