coral-web: update settings drawer with toggle cards #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wujessica
requested review from
EugeneLightsOn,
malexw,
scottmx81,
tianjing-li and
a team
as code owners
wujessica
force-pushed
the
jw/new-composer-changes-pt-3
branch
from
f51738d to
f8ab403
Compare
misspia-cohere
approved these changes
Jun 20, 2024
knajjars
approved these changes
Jun 21, 2024
wujessica
force-pushed
the
jw/new-composer-changes-pt-3
branch
from
f8ab403 to
86a9061
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage ? 86.66%
=======================================
Files ? 149
Lines ? 5549
Branches ? 0
=======================================
Hits ? 4809
Misses ? 740
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Closes OS-2175
This PR updates the settings drawer to reflect the latest designs. It adds toggle cards and separates tools by availability, ports over the change where deselecting the
search_filetool will deselect files in the composer, and re-organizes and renames components.Screen.Recording.2024-06-19.at.1.42.34.PM.mov
If there are errors and the tool is unavailable the toggle is hidden + error is shown:
AI Description
This PR introduces a new
SettingsDrawercomponent and makes corresponding changes to replace theConfigurationDrawercomponent.ConfigurationDrawercomponent and its imports have been removed.SettingsDrawercomponent has been added, which includes tabs for tools, files, and settings.FilesTabandToolsTabcomponents have been added to display file and tool information.FilesandToolscomponents have been removed, and their functionality integrated into the new tabs.Settingscomponent has been renamed toSettingsTab.Switchcomponent has been updated to include a Field wrapper and style changes.ToggleCardcomponent has been added to display tool information with a toggle.