Add OIDC auth strategy, add Blacklist scaffolding (model/schema/crud) #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianjing-li
requested review from
EugeneLightsOn,
malexw,
scottmx81 and
a team
as code owners
scott-cohere
previously approved these changes
Jun 10, 2024
tianjing-li
had a problem deploying
to
development
GitHub Actions
Failure
tianjing-li
had a problem deploying
to
development
GitHub Actions
Failure
scott-cohere
approved these changes
Jun 12, 2024
ClaytonSmith
pushed a commit
to MiniMap-ai/cohere-toolkit
that referenced
this pull request
Jun 13, 2024
…cohere-ai#190) * add oidc, blacklist logic * Add auth * Add logic for GET /auth * Mods
ClaytonSmith
added a commit
to MiniMap-ai/cohere-toolkit
that referenced
this pull request
Jun 17, 2024
* [coral-web] rename schema fields and update openapi client (cohere-ai#189) * update * update client * Add use agents view env variable. (cohere-ai#192) * Change * Format * [backend] api_key not set for class methods (cohere-ai#191) * fix * easier fix * perf: downgrade rehype-highlight and generate once blob url (cohere-ai#193) * perf: downgrade rehype-highlight and generate once blob url * fix: replace code blocks to iframe in conversation history * refactor: run format * refactor: pr feedback * Add OIDC auth strategy, add Blacklist scaffolding (model/schema/crud) (cohere-ai#190) * add oidc, blacklist logic * Add auth * Add logic for GET /auth * Mods * fix: html preview with citations (cohere-ai#200) * [backend] adding tools for agents, filter tools by agent_id (cohere-ai#204) * changes * lint * filter tools by agent * lint * update tests * lint and squash migrations * fix alembic migration err * lint * merge (#3) * [backend] make deployment field optional in API and DB (cohere-ai#213) --------- Co-authored-by: Tianjing Li <[email protected]> Co-authored-by: Tomeu <[email protected]> Co-authored-by: Scott <[email protected]> Co-authored-by: Beatrix De Wilde <[email protected]> * pulling from main * cleaned backend docker image push * syncing with main (conflicts) --------- Co-authored-by: Scott <[email protected]> Co-authored-by: Beatrix De Wilde <[email protected]> Co-authored-by: Tomeu <[email protected]> Co-authored-by: Tianjing Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces OpenID Connect as an authentication strategy, alongside the existing Google OAuth and Basic Authentication strategies. It also adds the base scaffolding for adding a JWT token blacklist during logouts.
Changes:
OpenIDConnectas an authentication strategy, including the necessary imports and class definition.src/backend/config/auth.pyfile to importOpenIDConnect.src/backend/services/auth/__init__.pyfile to importOpenIDConnect.src/backend/services/auth/strategies/oidc.pyfile for theOpenIDConnectstrategy implementation.src/backend/routers/auth.pyfile to include OpenID Connect-related endpoints (/oidc/authand/logout).Blacklisttable to store JWT access tokens that are blacklisted during logout.src/backend/tests/crud/test_blacklist.py.poetry.lockandpyproject.tomlfiles with new dependencies.