Skip to content

Fix async client chat being overridden as non async #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix async client chat being overridden as non async #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/cohere/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,21 @@
def validate_args(obj: typing.Any, method_name: str, check_fn: typing.Callable[[typing.Any], typing.Any]) -> None:
method = getattr(obj, method_name)

def wrapped(*args: typing.Any, **kwargs: typing.Any) -> typing.Any:
def _wrapped(*args: typing.Any, **kwargs: typing.Any) -> typing.Any:
check_fn(*args, **kwargs)
return method(*args, **kwargs)

async def _async_wrapped(*args: typing.Any, **kwargs: typing.Any) -> typing.Any:
# The `return await` looks redundant, but it's necessary to ensure that the return type is correct.
check_fn(*args, **kwargs)
return await method(*args, **kwargs)

wrapped = _wrapped
if asyncio.iscoroutinefunction(method):
wrapped = _async_wrapped

wrapped.__name__ = method.__name__
wrapped.__doc__ = method.__doc__
setattr(obj, method_name, wrapped)


Expand Down