Move models param to the endpoint rather than constructor #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the optional
chat_model,embed_model, andgenerate_modelparameters from the__init__method of theAwsClientclass and its subclassesBedrockClientandSagemakerClient. It also updates the test cases intests/test_aws_client.pyto use themodelsdictionary instead of hardcoding the model values.Summary of Changes
chat_model,embed_model, andgenerate_modelparameters from the__init__method of theAwsClientclass and its subclasses.tests/test_aws_client.pyto use themodelsdictionary for model values instead of hardcoding them.clientvariable tomodelsin theTestClientclass.modelsparameter to theparameterized_classdecorator intests/test_aws_client.py.