Skip to content

Conversation

@billytrend-cohere
Copy link
Collaborator

@billytrend-cohere billytrend-cohere commented Jun 6, 2024

This PR removes the optional chat_model, embed_model, and generate_model parameters from the __init__ method of the AwsClient class and its subclasses BedrockClient and SagemakerClient. It also updates the test cases in tests/test_aws_client.py to use the models dictionary instead of hardcoding the model values.

Summary of Changes

  • Removes the optional chat_model, embed_model, and generate_model parameters from the __init__ method of the AwsClient class and its subclasses.
  • Updates the test cases in tests/test_aws_client.py to use the models dictionary for model values instead of hardcoding them.
  • Renames the client variable to models in the TestClient class.
  • Adds the models parameter to the parameterized_class decorator in tests/test_aws_client.py.

@billytrend-cohere billytrend-cohere merged commit 2ed7109 into main Jun 6, 2024
@billytrend-cohere billytrend-cohere deleted the model-param-move branch June 6, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants