-
-
Notifications
You must be signed in to change notification settings - Fork 5
Update to v24.0.0 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wow I didn't realize they made so many changes in 24! Thank you for doing this!! One key thing: we have a strategy for updating the libs for all the platforms that is intended to not bloat the size of the repo every time these are updated, so please do not commit those at this point! |
Sure thing, I was intending on asking how this was to be done :) As a side question, I used to depend on https://github.com/rajveermalviya/go-webgpu, can I assume that this repo is its successor? |
Yep we've picked it up -- tried contacting rajveermalviya a few times but no responses, including to a PR to his repo. @kkoreilly added all the js bindings so it works under wasm. I guess he'll need to do that update now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to update to v25 now, grabbing your changes and updating as needed.
See commit
f29ebee
/PR gfx-rs/wgpu-native#455 for the commit/PR in wgpu-native which updates to v24.0.0.90% of the work is done and I've got it working on my machine, but there's a few more things I've got to do/sort out upstream in
wgpu-native
.To do (notes to self):
gowebgpu_error_callback_c
.I've been manually editingNothing, its all working as expected 🎉enums.go
; what do I have to do for the generated one to work?IsMaybe, but fix other issues ffi/wgpu.h: Typo in param name & GLSL shader source struct gfx-rs/wgpu-native#478wgpuDeviceCreateShaderModuleSpirV
still needed inwgpu-native
?ShouldwgpuDevicePoll
even take in aWGPUSubmissionIndex const *
? Should it not just beWGPUSubmissionIndex
?NULL
is valid too so no.wgpuglfw
.cmd/enums
, generate flags (currently being added manually to end of generated file). -> This is probably gonna be pretty difficult, as I don't know if there's an easy way to get the initializer for a declaration with the version of the C frontend package used. This says that it isn't maintained anymore, but that message is from 2020 and v4 seems to be actively maintained. Documentation for this package is really poor though and I can't find a comprehensive migration guide - I have sent an email to the author. Maybe we should just drop this and generate from the source YAML (Generate wgpu.h from yaml gfx-rs/wgpu-native#373).