COBOL language id can also be uppercase #1152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liam Allan <[email protected]>
Signed-off-by: Liam Allan <[email protected]>
|
@worksofliam Why is the regex for language ID case sensitive - wouldn't it be better to just ignore the casing? |
|
@chrjorgensen Good point. Got a demo to do today, so I will make sure to get it fixed after that! |
Signed-off-by: Liam Allan <[email protected]>
chrjorgensen
previously approved these changes
Mar 22, 2023
There was a problem hiding this comment.
@worksofliam Code is working as expected. I didn't test the default COBOL action setup, though...
Signed-off-by: Liam Allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
COBOL, whereas our regex was only checking forcobol.CRTBNDCBLandCRTCBLMODdoes not like unicode at all - but the good news is thatCRTSQLCBLIdoes!I have tested and is now working as expected.
Checklist
console.logs I added