Skip to content

⚡️ Speed up function known_nicknames by 113% #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function known_nicknames by 113% #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stanza/resources/default_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,11 +951,11 @@ def known_nicknames():

We return a list so that we can sort them in decreasing key length
"""
nicknames = list(value for key, value in TRANSFORMER_NICKNAMES.items())
nicknames = list(TRANSFORMER_NICKNAMES.values())

# previously unspecific transformers get "transformer" as the nickname
nicknames.append("transformer")

nicknames = sorted(nicknames, key=lambda x: -len(x))
nicknames.sort(key=len, reverse=True)

return nicknames