Skip to content

⚡️ Speed up function looks_like_url by 150% #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

⚡️ Speed up function looks_like_url by 150% #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion py-polars/src/polars/io/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
from collections.abc import Iterator, Sequence
from contextlib import AbstractContextManager as ContextManager

_URL_REGEX = re.compile(r"^(ht|f)tps?://", re.IGNORECASE)


def parse_columns_arg(
columns: Sequence[str] | Sequence[int] | str | int | None,
Expand Down Expand Up @@ -291,7 +293,7 @@ def _check_empty(


def looks_like_url(path: str) -> bool:
return re.match("^(ht|f)tps?://", path, re.IGNORECASE) is not None
return _URL_REGEX.match(path) is not None


def process_file_url(path: str, encoding: str | None = None) -> BytesIO:
Expand Down