⚡️ Speed up function _py_to_js by 53%
#89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 53% (0.53x) speedup for
_py_to_jsinplotly/serializers.py⏱️ Runtime :
1.41 milliseconds→920 microseconds(best of309runs)📝 Explanation and details
The optimized code achieves a 53% speedup by adding a fast path for primitive types early in the function. The key optimization is adding this check:
Why this works:
isinstance()checks even for simple primitivestype()with tuple membership testing, which is significantly faster than multipleisinstance()callsPerformance gains by test case:
The optimization also moves the
Undefinedcheck to the very beginning, which provides another small boost for that specific case. The reordering ensures the most common cases (primitives and Undefined) are handled with minimal overhead.✅ Correctness verification report:
🌀 Generated Regression Tests and Runtime
To edit these changes
git checkout codeflash/optimize-_py_to_js-mhggslq0and push.