⚡️ Speed up function endpts_to_intervals by 30%
#83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 30% (0.30x) speedup for
endpts_to_intervalsinplotly/figure_factory/_scatterplot.py⏱️ Runtime :
922 microseconds→710 microseconds(best of111runs)📝 Explanation and details
The optimized code achieves a 29% speedup through three key optimizations:
1. Combined Single-Pass Validation
The original code made two separate passes through the input: one to check for strings and another to verify increasing order. The optimized version combines both validations into a single loop using
enumerate(), reducing the number of iterations from 2×n to 1×n for the validation phase.2. Simplified Type Checking
Changed
isinstance(endpts, (tuple)) or isinstance(endpts, (list))to the more efficientisinstance(endpts, (list, tuple)), eliminating redundant function calls and logical operations.3. Efficient Interval Construction
Replaced the original approach of creating empty lists and appending elements individually with:
intervals = [[float("-inf"), endpts[0]]][[endpts[k], endpts[k + 1]] for k in range(length - 1)]intervals.extend()instead of individual appendsPerformance Characteristics by Test Case:
The optimizations particularly excel with larger datasets where the reduced algorithmic complexity (fewer passes) and more efficient list construction methods provide substantial performance gains.
✅ Correctness verification report:
🌀 Generated Regression Tests and Runtime
To edit these changes
git checkout codeflash/optimize-endpts_to_intervals-mhgbaabaand push.