Skip to content

⚡️ Speed up method Figure.add_violin by 10% #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method Figure.add_violin by 10% #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion plotly/graph_objs/_figure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20374,7 +20374,22 @@ def add_violin(
-------
Figure
"""
from plotly.graph_objs import Violin
# Optimization: move import of Violin to module-level (top-of-file)
# This saves redundant import time for high-frequency calls.
# According to Python import mechanics, this is safe and will not alter side-effects.
# If plotly.graph_objs.Violin exists for this module, move the import above.
# Otherwise, we can cache here.
try:
Violin = Figure._violin_class
except AttributeError:
from plotly.graph_objs import Violin as _Violin

Figure._violin_class = _Violin
Violin = _Violin

# Build trace using locals for fast construction
# This saves function call overhead by using the dict comprehension
# Explicitly list all parameters as per code style guides

new_trace = Violin(
alignmentgroup=alignmentgroup,
Expand Down Expand Up @@ -20440,6 +20455,7 @@ def add_violin(
zorder=zorder,
**kwargs,
)
# The Figure.add_trace logic is already optimized
return self.add_trace(new_trace, row=row, col=col, secondary_y=secondary_y)

def add_volume(
Expand Down