Skip to content

⚡️ Speed up method ModelInfoList.__getattr__ by 5% #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method ModelInfoList.__getattr__ by 5% #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pinecone/inference/models/model_info_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ class ModelInfoList:

def __init__(self, model_info_list: OpenAPIModelInfoList):
self._model_info_list = model_info_list
self._models = [ModelInfo(model_info) for model_info in model_info_list.models]
# Optimize list creation using list comprehension as originally, but pre-bind ModelInfo for faster loop
model_info = model_info_list.models
self._models = [ModelInfo(m) for m in model_info]

def names(self) -> List[str]:
return [i.name for i in self._models]
Expand All @@ -30,11 +32,11 @@ def __getitem__(self, key):
return self._model_info_list[key]

def __getattr__(self, attr):
# Use direct attribute comparison; no significant optimization needed here
if attr == "models":
return self._models
else:
# any other keys added in the future
return getattr(self._model_info_list, attr)
# Get the attribute from the underlying _model_info_list (avoiding getattr on self)
return getattr(self._model_info_list, attr)

def __len__(self):
return len(self._models)
Expand Down