Skip to content

⚡️ Speed up method IndexHostStore.get_host by 37% #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method IndexHostStore.get_host by 37% #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions pinecone/db_control/index_host_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def __init__(self) -> None:
self._indexHosts = {}

def _key(self, config: Config, index_name: str) -> str:
return ":".join([config.api_key, index_name])
return config.api_key + ":" + index_name

def delete_host(self, config: Config, index_name: str):
key = self._key(config, index_name)
Expand All @@ -40,14 +40,20 @@ def set_host(self, config: Config, index_name: str, host: str):
self._indexHosts[key] = normalize_host(host)

def get_host(self, api: IndexOperationsApi, config: Config, index_name: str) -> str:
key = self._key(config, index_name)
if self.key_exists(key):
return self._indexHosts[key]
else:
# Cache key and _indexHosts locally to avoid attribute and method lookups
key = f"{config.api_key}:{index_name}"
store = self._indexHosts
try:
return store[key]
except KeyError:
# Directly update in the store to avoid extra attribute lookup
description = api.describe_index(index_name)
self.set_host(config, index_name, description.host)
if not self.key_exists(key):
host = description.host
if host:
normalized = normalize_host(host)
store[key] = normalized
if key not in store:
raise PineconeException(
f"Could not get host for index: {index_name}. Call describe_index('{index_name}') to check the current status."
)
return self._indexHosts[key]
return store[key]