Skip to content

⚡️ Speed up method SearchQueryVector.as_dict by 118% #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method SearchQueryVector.as_dict by 118% #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions pinecone/db_data/dataclasses/search_query_vector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,15 @@ def as_dict(self) -> dict:
"""
Returns the SearchQueryVector as a dictionary.
"""
d = {
"values": self.values,
"sparse_values": self.sparse_values,
"sparse_indices": self.sparse_indices,
}
return {k: v for k, v in d.items() if v is not None}
# Directly construct the dictionary only with non-None attributes
result = {}
values = self.values
if values is not None:
result["values"] = values
sparse_values = self.sparse_values
if sparse_values is not None:
result["sparse_values"] = sparse_values
sparse_indices = self.sparse_indices
if sparse_indices is not None:
result["sparse_indices"] = sparse_indices
return result