Skip to content

⚡️ Speed up method GistSourceReader.can_read by 23% #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method GistSourceReader.can_read by 23% #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions marimo/_cli/file_path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,11 @@ def is_gist_src(url: str) -> bool:
if not is_url(url):
return False

hostname = urllib.parse.urlparse(url).hostname
if (
hostname != "gist.github.com"
and hostname != "gist.githubusercontent.com"
):
return False
return True
# Use urlparse only once and cache the result, avoid attribute access if possible
parsed = urllib.parse.urlparse(url)
hostname = parsed.hostname
# Use a set for O(1) membership tests
return hostname in {"gist.github.com", "gist.githubusercontent.com"}


def get_gist_src_url(url: str) -> str:
Expand Down Expand Up @@ -226,7 +224,8 @@ def read(self, name: str) -> tuple[str, str]:

class GistSourceReader(FileReader):
def can_read(self, name: str) -> bool:
return is_gist_src(name) or is_gist_src(name)
# Avoid double computation by only calling is_gist_src once
return is_gist_src(name)

def read(self, name: str) -> tuple[str, str]:
url = get_gist_src_url(name)
Expand Down