⚡️ Speed up function _is_code_tag by 71%
#397
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 71% (0.71x) speedup for
_is_code_taginmarimo/_convert/markdown/markdown.py⏱️ Runtime :
15.3 milliseconds→8.95 milliseconds(best of129runs)📝 Explanation and details
Explanation of Optimizations:
Optimize Regular Expressions in
_is_code_tag:Short-circuit logic in
_is_code_tag:True—this avoids an unnecessary check for the supported format (which is only needed if legacy_match isFalseand the dependency is available). This both speeds up function logic and clarifies intent.No change to
has_required_versionlogic in dependencies.py:Overall, the largest runtime improvements come from avoiding repeatedly compiling and matching regexes inside the hot
_is_code_tagfunction.✅ Correctness verification report:
🌀 Generated Regression Tests and Runtime
🔎 Concolic Coverage Tests and Runtime
codeflash_concolic_qdbuqf4z/tmpzaiyoc6b/test_concolic_coverage.py::test__is_code_tagTo edit these changes
git checkout codeflash/optimize-_is_code_tag-mh5l3ubrand push.