Skip to content

⚡️ Speed up function translation_file_changed by 146% #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function translation_file_changed by 146% #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions django/utils/translation/reloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
import gettext
from pathlib import Path

from asgiref.local import Local

from django.apps import apps
from django.utils.autoreload import is_django_module
from django.utils.translation import trans_real

_local_instance = Local()


def watch_for_translation_changes(sender, **kwargs):
Expand All @@ -25,12 +29,8 @@ def watch_for_translation_changes(sender, **kwargs):
def translation_file_changed(sender, file_path, **kwargs):
"""Clear the internal translations cache if a .mo file is modified."""
if file_path.suffix == ".mo":
import gettext

from django.utils.translation import trans_real

gettext._translations = {}
trans_real._translations = {}
gettext._translations.clear()
trans_real._translations.clear()
trans_real._default = None
trans_real._active = Local()
trans_real._active = _local_instance
return True