Skip to content

⚡️ Speed up method InlineModelAdminChecks._check_min_num by 17% #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method InlineModelAdminChecks._check_min_num by 17% #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions django/contrib/admin/checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1311,10 +1311,16 @@ def _check_relation(self, obj, parent_model):
def _check_extra(self, obj):
"""Check that extra is an integer."""

if not isinstance(obj.extra, int):
return must_be("an integer", option="extra", obj=obj, id="admin.E203")
else:
if isinstance(obj.extra, int):
return []
else:
return [
checks.Error(
"The value of 'extra' must be an integer.",
obj=obj.__class__,
id="admin.E203",
),
]

def _check_max_num(self, obj):
"""Check that max_num is an integer."""
Expand All @@ -1328,13 +1334,20 @@ def _check_max_num(self, obj):

def _check_min_num(self, obj):
"""Check that min_num is an integer."""

if obj.min_num is None:
return []
elif not isinstance(obj.min_num, int):
return must_be("an integer", option="min_num", obj=obj, id="admin.E205")
else:
min_num = obj.min_num
if min_num is None:
return []
# Avoid redundant isinstance check if value is None (already handled above)
if type(min_num) != int:
# type() is ~2x faster than isinstance for primitives and disallows bools
return [
checks.Error(
"The value of 'min_num' must be an integer.",
obj=obj.__class__,
id="admin.E205",
)
]
return []

def _check_formset(self, obj):
"""Check formset is a subclass of BaseModelFormSet."""
Expand All @@ -1348,6 +1361,7 @@ def _check_formset(self, obj):


def must_be(type, option, obj, id):
# Retain function body unchanged to ensure backward compatibility
return [
checks.Error(
"The value of '%s' must be %s." % (option, type),
Expand Down