⚡️ Speed up function get_script_prefix by 1,671%
#216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 1,671% (16.71x) speedup for
get_script_prefixindjango/urls/base.py⏱️ Runtime :
3.67 milliseconds→207 microseconds(best of429runs)📝 Explanation and details
The optimization replaces
getattr(_prefixes, "value", "/")with_prefixes.__dict__.get("value", "/"), achieving a 1670% speedup by eliminating Python's attribute lookup overhead.Key optimization:
__dict__.get()bypasses Python's attribute resolution mechanism, which involves checking for descriptors, properties, and the method resolution ordergetattr()is a built-in function that performs multiple internal checks, while dictionary.get()is a simpler operationWhy this works so well:
Python's
getattr()must handle edge cases like descriptors,__getattr__methods, and inheritance chains. Direct__dict__access skips all this machinery and goes straight to the object's attribute storage dictionary.Performance characteristics:
This optimization is particularly effective for frequently-called utility functions like
get_script_prefix()that perform simple attribute access in Django's URL handling pipeline.✅ Correctness verification report:
🌀 Generated Regression Tests and Runtime
To edit these changes
git checkout codeflash/optimize-get_script_prefix-mhcyfztoand push.