Make init job annotations optional #206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some kubernetes executors like argo will not deploy this chart correctly with these annotations. I've found that these annotations need to be removed and replaced with: ``` argocd.argoproj.io/hook: Sync argocd.argoproj.io/hook-delete-policy: HookFailed helm.sh/hook: null helm.sh/hook-delete-policy: null ```
|
Can you please add a test to cover this use case? |
|
This was addressed in #250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some kubernetes executors like ArgoCD will not deploy this chart correctly with the given annotations. I've found that these annotations need to be removed and replaced with:
This PR makes it possible to customize the annotations