kvstorage: introduce/use ReplicaMark #156696
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Epic: none Release note: none
Epic: none Release note: none
This commit make CreateUninitializedReplica and DestroyReplica use the new ReplicaMark type with stronger assertions. It also documents the existing bug in CreateUninitializedReplica, before we fix it. Epic: none Release note: none
Epic: none Release note: none
Epic: none Release note: none
Epic: none Release note: none
There are no more users of these methods. Going forward, LoadReplicaMark must be used instead. Epic: none Release note: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
ReplicaMarkconcept which encompasses both theRangeTombstoneandRaftReplicaID. The two are strongly related, and there is an invariant describing which combinations are allowed.The new
ReplicaMarktype strongly guards this invariant, and is used everywhere in code where previouslyRangeTombstoneandRaftReplicaIDwere used in a loosely coupled manner.This PR also documents an old bug in
CreateUninitializedReplica, existence of which can be partially attributed to not strongly couplingRangeTombstoneandRaftReplicaIDbefore this PR. There should be fewer footguns now.We will also use this type when replaying the WAG, to decide whether a WAG node has been applied.
ReplicaMarks can be compared.Related to #152845
Epic: CRDB-55220