Error in the auto-request-review workflow

[brandtkeller]

Description

Noted that there is some permutation of the auto-request-review workflow that returns an error due to required collaborator definition be met in order to add a reviewer. There must be an inconsistency somewhere.

[brandtkeller]

@eddie-knight @mnm678 This may be an admin activity for mapping what exists in the auto_request_review.yml file to collaborators in the repository settings perhaps?

[mnm678]

It seems like auto_request_review.yml used to be able to include non-collaborators (according to the comment at the top). I'm following up with the non-collaborators on this list to either get them removed from this list or added as collaborators for now, but we should look into what changed there.

[mrcdb]

I may be wrong, but there is an organization-level setting that allows restricting code reviews in org repos to members with explicit access only (therefore, excluding any user that is neither an org member or an external collaborator): https://docs.github.com/en/organizations/managing-organization-settings/managing-pull-request-reviews-in-your-organization .

This setting may have been enforced over time on the CNCF org level, is there any way we can get feedback on this?

[funnelfiasco]

I was about to open an issue for this, but I see there already is one. It's not clear to me that this is a high-value workflow, especially since it's been failing more often than not. I propose to drop the workflow instead.

[stale]

This issue has been automatically marked as inactive because it has not had recent activity.