Skip to content

Conversation

elezar
Copy link
Contributor

@elezar elezar commented Aug 26, 2024

Ignore issues / PRs with lifecycle/frozen label when marking them as stale / closing them.

klihub
klihub previously approved these changes Aug 26, 2024
@@ -14,10 +14,12 @@ jobs:
steps:
- uses: actions/stale@v9
with:
stale-issue-message: 'This issue is stale because it has been open 90 days with no activity. This issue will be closed in 30 days unless new comments are made or the stale label is removed.'
stale-pr-message: 'This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed.'
stale-issue-message: 'This issue is stale because it has been open 90 days with no activity. This issue will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the frozen label.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps "lifecycle/frozen" to prevent confusion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That would be better.

@klihub
Copy link
Contributor

klihub commented Aug 27, 2024

@elezar sign-off missing, I think...

@klihub klihub dismissed their stale review August 27, 2024 11:14

sign-off is missing from the topmost commit...

Ignore issues / PRs with `lifecycle/frozen` label when marking them as stale / closing them.

Signed-off-by: Evan Lezar <[email protected]>
@elezar
Copy link
Contributor Author

elezar commented Aug 27, 2024

@elezar sign-off missing, I think...

Yes. I made the original edits in the github UI. I've signed-off the commit now.

@elezar elezar requested review from thaJeztah and klihub August 27, 2024 12:18
Copy link
Contributor

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bart0sh bart0sh merged commit b355496 into main Aug 27, 2024
12 checks passed
@bart0sh bart0sh deleted the elezar-patch-1 branch November 26, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants