Skip to content

Conversation

JedGrabman
Copy link
Contributor

Several updates to phrasing in the about document.

@JedGrabman JedGrabman requested a review from kateharwood March 25, 2021 16:25
States, territories or U.S. as a nation

#### **Dashboard Inclusion Criteria**
A forecast is only included if all the following criteria are met:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this might be ambiguous what we mean by forecast here. It might be possible that someone could interpret this as "forecaster" and think that we are not including any forecaster that predicts cases and deaths but also other things, or any forecaster that also predicts for horizons 5 weeks ahead, etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A forecast is only included if all the following criteria are met:
A dataset is only included if all the following criteria are met:

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how else to phrase it. The inclusion criteria is based on (forecaster, location, horizon, target) combinations, which we defined above as a "forecast".

I don't agree with using "dataset", since there are many different things that could be considered a dataset, so I find the phrase less clear.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair, we do define forecast explicitly above. Maybe we should change the definition of "Forecaster" above to say "A model producing forecasts." That would be even clearer (and better than what I had there I think).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I updated that and some of the surrounding terms. I think it's clearer, although the phrasing was tricky to decide.

JedGrabman and others added 2 commits March 25, 2021 14:16
Co-authored-by: Katie Mazaitis <[email protected]>
@JedGrabman JedGrabman requested a review from kateharwood March 26, 2021 14:54
@kateharwood kateharwood merged commit f881c51 into dev Mar 30, 2021
@kateharwood kateharwood deleted the dev-about-update branch March 30, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants