-
Notifications
You must be signed in to change notification settings - Fork 3
Update about.md #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update about.md #80
Conversation
States, territories or U.S. as a nation | ||
|
||
#### **Dashboard Inclusion Criteria** | ||
A forecast is only included if all the following criteria are met: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this might be ambiguous what we mean by forecast here. It might be possible that someone could interpret this as "forecaster" and think that we are not including any forecaster that predicts cases and deaths but also other things, or any forecaster that also predicts for horizons 5 weeks ahead, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A forecast is only included if all the following criteria are met: | |
A dataset is only included if all the following criteria are met: |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how else to phrase it. The inclusion criteria is based on (forecaster, location, horizon, target) combinations, which we defined above as a "forecast".
I don't agree with using "dataset", since there are many different things that could be considered a dataset, so I find the phrase less clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair, we do define forecast explicitly above. Maybe we should change the definition of "Forecaster" above to say "A model producing forecasts." That would be even clearer (and better than what I had there I think).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I updated that and some of the surrounding terms. I think it's clearer, although the phrasing was tricky to decide.
Co-authored-by: Katie Mazaitis <[email protected]>
Several updates to phrasing in the about document.