Dashboard dev #17
Merged
Dashboard dev #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kateharwood have you pushed your current work on this PR, and/or is it ready to review? |
|
@tildechris I just pushed my latest changes. It's up to you if you would rather review it and merge now or wait until it's mostly finalized. I still have things to add, and there are still TODOs to address in the code. |
|
I took a brief look and nothing stuck out to me as wrong, but it's been a long time since I've touched anything Shiny. |
tildechris
reviewed
Feb 25, 2021
tildechris
reviewed
Feb 25, 2021
tildechris
reviewed
Feb 25, 2021
tildechris
reviewed
Feb 25, 2021
tildechris
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
LGTM, I left several nits, but don't feel compelled to change. BTW, if you have known todos, you can open issues to track them, which would let you merge this now and then address the remaining work in separate PRs.
That would make it easier to see what work is remaining.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to date with where the dashboard is now. I want to get this on the staging server so I can send the link out so people can have the most recent version when thinking about revisions.