Skip to content

Consider caching old common location set to check if we should rerender the truth plot, instead of using an observer #272

@nmdefries

Description

@nmdefries

To save plot rendering/computation time in #271, we could also save the previous locationsIntersect to a user session-specific global and check during the next call to summaryPlot() if it has changed. If locationsIntersect has changed, make a new truth plot.

Potential problems:

  • Because it is in an observer, the re-plotting logic in
    locationsIntersect <- filteredScoreDfAndIntersections[[2]]
    is confined to cases where the forecaster selection has changed. If we move the logic to summaryPlot() truth re-plotting could be triggered in other cases that we don't need/want.
  • It's unclear how much extra time making a new truth plot takes. The re-plotting logic re-renders the old plot and rendering is slow.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions