Skip to content

Conversation

@simongong
Copy link

With this, user can specify a preferred message template which will be shown in the git editor.

@cmalard
Copy link
Owner

cmalard commented Mar 6, 2016

Hi simongong, nice PR :-)
I'm curious about the template you are using, is it worth to include it in the PR?

@simongong
Copy link
Author

Hi, I'm glad you like it :-).

Currently we're using the same angular-convention template. This PR is originally from the idea that I wanted to use a team-and-locale-preferred template so I didn't include it in the PR.

Still, I'll send a PR with new template if we have a more generic one in future, e.g. a template with non-angular-convention.

Many thanks to you for this great tool! It's so cool!

@simongong
Copy link
Author

@cmalard just in case you didn't get notification from Github for my last reply :-)

Copy link
Owner

@cmalard cmalard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @simongong, sorry for the delay ! :-)
Are you still using this hook ?
Do you use another template ?

index.js Outdated
# - no dot (.) at the end
#---
# https://github.com/ajoslin/conventional-changelog/blob/master/conventions/angular.md
var scissorsLine = '# ---------- Message Formatting Convention ----------';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scissors line is a default in Git and displayed when you do a git commit -v.
I use it to insert the message after any existing commit message and before the diff of changes.
You should not change it, but you can add Message Formatting Convention to the template :-)

@simongong
Copy link
Author

Hi, scissorsLine is back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants