-
Notifications
You must be signed in to change notification settings - Fork 2
Add -t option to support customizing message template
#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi simongong, nice PR :-) |
|
Hi, I'm glad you like it :-). Currently we're using the same angular-convention template. This PR is originally from the idea that I wanted to use a team-and-locale-preferred template so I didn't include it in the PR. Still, I'll send a PR with new template if we have a more generic one in future, e.g. a template with non-angular-convention. Many thanks to you for this great tool! It's so cool! |
|
@cmalard just in case you didn't get notification from Github for my last reply :-) |
cmalard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @simongong, sorry for the delay ! :-)
Are you still using this hook ?
Do you use another template ?
index.js
Outdated
| # - no dot (.) at the end | ||
| #--- | ||
| # https://github.com/ajoslin/conventional-changelog/blob/master/conventions/angular.md | ||
| var scissorsLine = '# ---------- Message Formatting Convention ----------'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scissors line is a default in Git and displayed when you do a git commit -v.
I use it to insert the message after any existing commit message and before the diff of changes.
You should not change it, but you can add Message Formatting Convention to the template :-)
|
Hi, scissorsLine is back! |
With this, user can specify a preferred message template which will be shown in the git editor.