Skip to content

Conversation

Hiroki6
Copy link

@Hiroki6 Hiroki6 commented Jun 13, 2025

what

add cloudwatch_event_rule_pattern_detail variable to customize the event filter.
Basically a similar implementation of #59, which also added this variable.
Since the original PR has been open more than 1 year and seems to be stale, I opened the PR.

why

The default event pattern sends a lot of alerts.
This variable allows to customize the detail pattern to filter events.

@Hiroki6 Hiroki6 requested review from a team as code owners June 13, 2025 08:02
@Hiroki6 Hiroki6 requested review from gberenice and hans-d June 13, 2025 08:02
@mergify mergify bot added the triage Needs triage label Jun 13, 2025
@gberenice
Copy link

/terratest

@gberenice
Copy link

@Hiroki6 thanks for your contribution!
This is not directly related to your PR, but can I ask you to address this issue to satisfy the failing checks for this output?

Running output-descriptions in /__w/terraform-aws-security-hub/terraform-aws-security-hub/examples/complete
1..1

Test: check if terraform outputs have descriptions
---------------------------------
sns_topic is missing a description
---------------------------------

@Hiroki6
Copy link
Author

Hiroki6 commented Jun 13, 2025

@Hiroki6 thanks for your contribution! This is not directly related to your PR, but can I ask you to address this issue to satisfy the failing checks for this output?

Running output-descriptions in /__w/terraform-aws-security-hub/terraform-aws-security-hub/examples/complete
1..1

Test: check if terraform outputs have descriptions
---------------------------------
sns_topic is missing a description
---------------------------------

@gberenice done.

@Hiroki6 Hiroki6 force-pushed the feature/add-event-rule-pattern-detail branch from f83a28a to a09cdc8 Compare June 13, 2025 13:58
@Hiroki6 Hiroki6 force-pushed the feature/add-event-rule-pattern-detail branch from a09cdc8 to 6e96777 Compare June 13, 2025 14:00
@gberenice
Copy link

/terratest

@gberenice
Copy link

@Hiroki6 ah, the last thing:

not ok 1 check if terraform code needs formatting
# (in test file /test/terraform/lint.bats, line 9)
#   `[ -z "$output" ]' failed
+ status=fail
+ for test in $tests
+ printf '\n\nRunning output-descriptions in /__w/terraform-aws-security-hub/terraform-aws-security-hub/examples/complete\n'

...

 output "sns_topic" {
   description = "The SNS topic that was created"
-  value = module.example.sns_topic
+  value       = module.example.sns_topic
 }

Mind run terraform fmt against the code, please?

@Hiroki6
Copy link
Author

Hiroki6 commented Jun 16, 2025

@Hiroki6 ah, the last thing:

not ok 1 check if terraform code needs formatting
# (in test file /test/terraform/lint.bats, line 9)
#   `[ -z "$output" ]' failed
+ status=fail
+ for test in $tests
+ printf '\n\nRunning output-descriptions in /__w/terraform-aws-security-hub/terraform-aws-security-hub/examples/complete\n'

...

 output "sns_topic" {
   description = "The SNS topic that was created"
-  value = module.example.sns_topic
+  value       = module.example.sns_topic
 }

Mind run terraform fmt against the code, please?

ah, sorry.
I ran terraform fmt .
Hope the ci passes now

@Hiroki6
Copy link
Author

Hiroki6 commented Jun 25, 2025

@gberenice can you rerun the test please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Needs triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants