-
-
Notifications
You must be signed in to change notification settings - Fork 0
Bugfix: Invalid Policy #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change updates the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Adding label |
These changes were released in v1.537.0. |
TL;DR
Bugfixing the policy in the SQS file. This bug is present since #6 where Mergify & Rennovate updated our module to 2.0.2 but that was a breaking change. We do not yet have tests for this component which wouldve caught it.
This pull request updates the structure of the
iam_policy
in thesqs_iam_policy
module to use a list format instead of a map. This change ensures compatibility with downstream modules that expect a list format.Changes to
iam_policy
structure:src/triggers_sqs_queue.tf
: Updatediam_policy
from a map to a list of maps in thesqs_iam_policy
module. This involves wrapping the policy definition in square brackets to convert it into a list. [1] [2]Summary by CodeRabbit