Skip to content

Conversation

Benbentwo
Copy link
Contributor

@Benbentwo Benbentwo commented Jul 31, 2025

TL;DR

Bugfixing the policy in the SQS file. This bug is present since #6 where Mergify & Rennovate updated our module to 2.0.2 but that was a breaking change. We do not yet have tests for this component which wouldve caught it.


This pull request updates the structure of the iam_policy in the sqs_iam_policy module to use a list format instead of a map. This change ensures compatibility with downstream modules that expect a list format.

Changes to iam_policy structure:

  • src/triggers_sqs_queue.tf: Updated iam_policy from a map to a list of maps in the sqs_iam_policy module. This involves wrapping the policy definition in square brackets to convert it into a list. [1] [2]

Summary by CodeRabbit

  • Chores
    • Updated configuration format for IAM policy settings to improve compatibility. No changes to functionality or user experience.

Copy link

coderabbitai bot commented Jul 31, 2025

Walkthrough

The change updates the iam_policy argument in the module "sqs_iam_policy" block within src/triggers_sqs_queue.tf, converting it from a single map/object to a list containing one map/object. No other logic, resource references, or conditions were modified.

Changes

Cohort / File(s) Change Summary
SQS IAM Policy Argument Update
src/triggers_sqs_queue.tf
Changed iam_policy from a single map/object to a list with one map/object in the module block.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hop and a skip through the queue we go,
A policy wrapped, now in list form to show.
One little change, as simple as pie,
The SQS rabbit just hopped right by.
With carrots and code, we keep things neat—
Terraform’s garden is now complete! 🥕

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b5ae9d and be7676f.

📒 Files selected for processing (1)
  • src/triggers_sqs_queue.tf (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Summary
🔇 Additional comments (1)
src/triggers_sqs_queue.tf (1)

41-50: iam_policy correctly wrapped in a list – LGTM

Switching the policy from a map to a single-element list matches the input schema introduced in cloudposse/iam-policy v2.x. No issues spotted with the new structure.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix-sqs-queue-policy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mergify mergify bot requested review from a team July 31, 2025 17:40
@mergify mergify bot added the triage Needs triage label Jul 31, 2025
@Benbentwo Benbentwo added the minor New features that do not break anything label Jul 31, 2025
@Benbentwo
Copy link
Contributor Author

Adding label minor as this previously shouldve been a minor release when #34 was merged.

@Benbentwo Benbentwo enabled auto-merge July 31, 2025 17:48
@Benbentwo Benbentwo added this pull request to the merge queue Jul 31, 2025
@mergify mergify bot removed the triage Needs triage label Jul 31, 2025
Merged via the queue into main with commit 10f807b Jul 31, 2025
14 checks passed
@Benbentwo Benbentwo deleted the bugfix-sqs-queue-policy branch July 31, 2025 17:56
Copy link

These changes were released in v1.537.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants