Skip to content

Alarm props is optional #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Alarm props is optional #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,8 +1042,8 @@ export class Container<Env = unknown> extends DurableObject<Env> {
* Executes any scheduled tasks that are due
*/

override async alarm(alarmProps: { isRetry: boolean; retryCount: number }): Promise<void> {
if (alarmProps.isRetry && alarmProps.retryCount > MAX_ALARM_RETRIES) {
override async alarm(alarmProps?: { isRetry: boolean; retryCount: number }): Promise<void> {
if (alarmProps?.isRetry && alarmProps?.retryCount > MAX_ALARM_RETRIES) {
Comment on lines +1045 to +1046
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
override async alarm(alarmProps?: { isRetry: boolean; retryCount: number }): Promise<void> {
if (alarmProps?.isRetry && alarmProps?.retryCount > MAX_ALARM_RETRIES) {
override async alarm(alarmProps?: AlarmInvocationInfo): Promise<void> {
if (alarmProps?.isRetry && alarmProps?.retryCount > MAX_ALARM_RETRIES) {

(i know this was already here, but while we're in the area we may as well make this use the actual type from workers-types instead of redefining it)

const scheduleCount =
Number(this.sql`SELECT COUNT(*) as count FROM container_schedules`[0]?.count) || 0;
const hasScheduledTasks = scheduleCount > 0;
Expand Down