Skip to content

Conversation

@diegodiv
Copy link
Contributor

The goal of this PR is to make Clash's flake usable with newer versions of GHC - 9.6.2 has this notorious problem where it throws an error when you output VHDL/Verilog. I enabled support for 9.6.6 and 9.8.2 in flake.nix along with updating flake.lock.

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files

@christiaanb christiaanb removed their request for review September 25, 2024 14:17
@diegodiv diegodiv requested a review from rowanG077 October 8, 2024 11:32
@diegodiv
Copy link
Contributor Author

I changed the default version to GHC 9.10 for different reasons:

  • It's the newest version and it is stable enough - and supported by Clash.
  • We encountered some issues on other projects with older versions of GHC, especially with the interaction between clash-cores and Cabal, and directly going for GHC 9.10 solves the issue without having to resort to modifications like this one.

@diegodiv diegodiv marked this pull request as ready for review October 15, 2024 08:50
@diegodiv diegodiv changed the title Update flake.nix to make GHC 9.6.6 and GHC 9.8.2 available Update flake.nix to make GHC 9.10,1 and GHC 9.8.2 available Oct 29, 2024
Copy link
Member

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nix/overlay.nix Outdated
{ };
# doctest-parallel = hprev.callHackage "doctest-parallel" "0.3.1" { };
doctest-parallel = hprev.callHackageDirect { pkg = "doctest-parallel"; ver = "0.3.1"; sha256 = "sha256-j0mk4RTEau6Cl90E8vMWZiA/ldRRurtLSYbGGE+q/vk="; } {};
# doctest-parallel = hprev.callHackageDirect { pkg = "doctest-parallel"; ver = "0.3.1"; sha256 = "sha256-j0mk4RTEau6Cl90E8vMWZiA/ldRRurtLSYbGGE+q/vk="; } {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with this? Can't we simply remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess we can just remove it indeed!

@diegodiv diegodiv merged commit a50b496 into master Feb 10, 2025
13 checks passed
@diegodiv diegodiv deleted the dd/nix-update branch February 10, 2025 11:39
jaschutte pushed a commit that referenced this pull request Oct 31, 2025
* Update GHC 9.6.2 to 9.6.6.

* Enable GHC 9.8.2 and remove GHC 9.0.2.

* Export ghcVersion from flake.nix.

* Remove Hackage calls for packages already in nixpkgs.

* Add GHC 9.10.1.

* Add comments to overlays.

* Make GHC 9.10 the default in flake.nix.

* Remove commented code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants