Skip to content

Type regression (express.Request -> http.IncomingMessage) #692

@elado

Description

@elado

Describe the feature you'd love to see

#603 reworked some types, but changed

// Request is extending express.Request
onProxyReq?(proxyReq: http.ClientRequest, req: Request, res: Response): void;

to

export type OnProxyReqCallback = (
  proxyReq: http.ClientRequest,
  req: http.IncomingMessage,
  res: http.ServerResponse,
  options: httpProxy.ServerOptions
) => void;

this changed req: express.Request to req: http.IncomingMessage which loses some properties like secure, query etc.

Additional context (optional)

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions