Fix for issue when layout is rotated #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @joshleibsly ! |
|
@chiahsien Yes, sure! I'll reopen this PR when I get to that later today. |
|
@chiahsien Should be good to go. Hopefully I can get around to actually adding horizontal scrolling soon :) |
|
Good job! Thanks @joshleibsly |
chiahsien
added a commit
that referenced
this pull request
May 15, 2015
Fix for issue when layout is rotated
|
@chiahsien |
|
This weekend or next weekdays. |
|
Thanks! |
|
@joshleibsly Hi，we want to know how to support horizontal scrolling？thks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chiahsien We were having issues with the frame vs. bounds values when we rotated the view to support horizontal scrolling (admittedly, I've been meaning to look into adding this support, but we were in a time crunch :) ), and iOS sometimes has a discrepancy between frame and bounds values when adjusting the transform of a view. Let me know if you have any concerns here!