feat: add optional default config support for monitors [sc-24878] #1109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorccu
force-pushed
the
simokinnunen/sc-24878/cli-apply-retry-strategy-limits-for-monitors
branch
from
f7a2616 to
a231ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional default config section for monitors. The reason why a separate default config may be necessary is that some of the check defaults may be incompatible with monitors. For example, #1106 makes it so that monitors only support a subset of retry strategies available to checks.
There is no separate file pattern for monitors. Only default configuration can be changed.
Monitor config defaults fall back to check config defaults.
Affected Components
Notes for the Reviewer
New Dependency Submission