Improvements on error handling #69
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb-haripriyan
requested changes
Aug 30, 2023
| STORE_PROBLEM(2010), | ||
| INVALID_RECEIPT(2011), | ||
| REQUEST_FAILED(2012), | ||
| PRODUCT_PURCHASED_ALREADY(2013); |
There was a problem hiding this comment.
Should include system error and restore errors here?
| } | ||
| case let .failure(error): | ||
| _result(FlutterError.productIdentifierError(error.localizedDescription)) | ||
| _result(FlutterError.productIdentifierError(error)) |
There was a problem hiding this comment.
Can we update the example to denote how to handle the errors?
| BillingClient.BillingResponseCode.USER_CANCELED -> PURCHASE_CANCELLED | ||
| BillingClient.BillingResponseCode.ITEM_UNAVAILABLE -> PRODUCT_NOT_AVAILABLE | ||
| BillingClient.BillingResponseCode.DEVELOPER_ERROR -> INVALID_PURCHASE | ||
| BillingClient.BillingResponseCode.ITEM_ALREADY_OWNED -> PRODUCT_PURCHASED_ALREADY |
There was a problem hiding this comment.
Can we add the corresponding error codes in dart as well?
| BILLING_UNAVAILABLE(2021), | ||
| ITEM_UNAVAILABLE(2022), | ||
| ITEM_NOT_OWNED(2023), | ||
| ITEM_ALREADY_OWNED(2024), |
There was a problem hiding this comment.
We should add these right?
… enum values to pass
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.