Skip to content

Conversation

@dinohan
Copy link
Member

@dinohan dinohan commented Oct 23, 2025

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

  • Update typography size 16 line-height from 22 to 24
  • Update typography size 17 line-height from 22 to 24
  • This change improves text readability and spacing consistency

Details

Breaking change? (Yes/No)

References

Summary by CodeRabbit

  • 버그 수정
    • 타이포그래피의 라인 높이를 사이즈 16 및 17에서 22 → 24로 조정하여 텍스트 가독성과 줄 간격 일관성이 개선되었습니다.
    • 소규모 스타일 조정으로 읽기 경험이 향상되며 UI 전반의 시각적 안정성이 증대됩니다.

@dinohan dinohan requested a review from yangwooseong as a code owner October 23, 2025 06:09
@dinohan dinohan self-assigned this Oct 23, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2025

🦋 Changeset detected

Latest commit: 0c01e3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@channel.io/bezier-tokens Patch
@channel.io/bezier-react Patch
bezier-vscode Patch
@channel.io/stylelint-bezier Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@channeltalk
Copy link

channeltalk bot commented Oct 23, 2025

@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025

Walkthrough

두 개의 타이포그래피 크기(16과 17)의 줄 높이를 22에서 24로 증가시키는 변경 사항입니다. 관련 패치 릴리스 항목이 추가되었으며, 이는 가독성과 간격 일관성을 개선합니다.

Changes

응집 / 파일(들) 변경 요약
타이포그래피 줄 높이 업데이트
.changeset/typography-line-height-fix-v3.md
패치 릴리스 항목 추가: 타이포그래피 크기 16, 17의 줄 높이 개선 사항 문서화
토큰 값 조정
packages/bezier-tokens/src/global/typography.json
타이포그래피 크기 16, 17의 줄 높이 값을 22에서 24로 증가

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 타이포그래피 숲 속을 뛰어다니며,
줄 높이를 두 칸 높였네요.
숫자 16, 17이 춤을 추고,
22에서 24로 우아하게 상승하니,
글자들이 한숨 쉴 공간이 생겼어요. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed PR 제목은 Conventional Commits 형식("fix(typography): ...")을 정확히 따르고 있으며, 변경 사항을 명확하게 요약하고 있습니다. "typography"의 line-height를 size 16과 17에 대해 22에서 24로 업데이트한다는 구체적인 내용이 제시되어 있으며, 이는 raw_summary와 pr_objectives의 내용과 완전히 일치합니다. 제목은 간결하면서도 팀원이 변경사항을 즉시 이해할 수 있을 정도로 충분한 맥락을 제공합니다.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed PR 설명이 대부분 완성되었습니다. 자체 체크리스트가 모두 표시되었고 요약 섹션에서는 typography 크기 16과 17의 line-height 변경 내용과 의도(가독성 및 간격 일관성 개선)가 명확하게 기술되어 있습니다. 다만 "Breaking change?" 섹션이 명시적으로 답변되지 않았으며, Details와 References 섹션이 비어 있습니다. 하지만 이러한 section들은 이 정도의 작은 typography 수정에서는 필수적이지 않은 보조적 정보로 볼 수 있습니다.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

- Update typography size 16 line-height from 22 to 24
- Update typography size 17 line-height from 22 to 24
- This change improves text readability and spacing consistency
@dinohan dinohan force-pushed the hotfix/typography-line-height-v3 branch from 03198d5 to 0c01e3a Compare October 23, 2025 06:11
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

Chromatic Report

🚀 Congratulations! Your build was successful!

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.30%. Comparing base (02146b7) to head (0c01e3a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2704   +/-   ##
=======================================
  Coverage   79.30%   79.30%           
=======================================
  Files         146      146           
  Lines        2909     2909           
  Branches      932      926    -6     
=======================================
  Hits         2307     2307           
+ Misses        598      567   -31     
- Partials        4       35   +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dinohan dinohan added design update Issue or PR that Up-to-date specifications for design system updates bezier-tokens Issue or PR related to bezier-tokens labels Oct 23, 2025
@dinohan dinohan merged commit 3bad1dd into channel-io:main Oct 23, 2025
7 checks passed
yangwooseong added a commit that referenced this pull request Oct 23, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @channel.io/[email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]

## @channel.io/[email protected]

### Patch Changes

- fix(typography): update line-height for size 16 and 17 from 22 to 24
([#2704](#2704)) by
@dinohan

    -   Update typography size 16 line-height from 22 to 24
    -   Update typography size 17 line-height from 22 to 24
    -   This change improves text readability and spacing consistency

## @channel.io/[email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]

## [email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]

## [email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

## 릴리스 노트

* **버그 수정**
  * 타이포그래피 크기 16과 17의 줄 높이를 개선하여 가독성과 간격 최적화

* **의존성 업데이트**
  * 관련 패키지의 버전이 업데이트되어 최신 타이포그래피 개선사항 적용

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bezier-tokens Issue or PR related to bezier-tokens design update Issue or PR that Up-to-date specifications for design system updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants