-
Notifications
You must be signed in to change notification settings - Fork 52
fix(typography): update line-height for size 16 and 17 from 22 to 24 #2704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typography): update line-height for size 16 and 17 from 22 to 24 #2704
Conversation
🦋 Changeset detectedLatest commit: 0c01e3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Walkthrough두 개의 타이포그래피 크기(16과 17)의 줄 높이를 22에서 24로 증가시키는 변경 사항입니다. 관련 패치 릴리스 항목이 추가되었으며, 이는 가독성과 간격 일관성을 개선합니다. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
- Update typography size 16 line-height from 22 to 24 - Update typography size 17 line-height from 22 to 24 - This change improves text readability and spacing consistency
03198d5 to
0c01e3a
Compare
Chromatic Report🚀 Congratulations! Your build was successful! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2704 +/- ##
=======================================
Coverage 79.30% 79.30%
=======================================
Files 146 146
Lines 2909 2909
Branches 932 926 -6
=======================================
Hits 2307 2307
+ Misses 598 567 -31
- Partials 4 35 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/[email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] ## @channel.io/[email protected] ### Patch Changes - fix(typography): update line-height for size 16 and 17 from 22 to 24 ([#2704](#2704)) by @dinohan - Update typography size 16 line-height from 22 to 24 - Update typography size 17 line-height from 22 to 24 - This change improves text readability and spacing consistency ## @channel.io/[email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] ## [email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] ## [email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## 릴리스 노트 * **버그 수정** * 타이포그래피 크기 16과 17의 줄 높이를 개선하여 가독성과 간격 최적화 * **의존성 업데이트** * 관련 패키지의 버전이 업데이트되어 최신 타이포그래피 개선사항 적용 <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Self Checklist
Related Issue
Summary
Details
Breaking change? (Yes/No)
References
Summary by CodeRabbit