Fix Object constructor behavior when new target is provided #6341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boingoing
approved these changes
Jan 3, 2020
|
I've run the benchmark suite on this, there's no reliable performance impact based on them - I don't know if we could microbenchmark to assess more specifically? That said - this has given me a thought, IsConstructorSuperCall is used heavily all over the place, could all functions that use it be made into template calls with their callers establishing the point? (idea extracted as #6407) @zenparsing All that aside - ok for us to merge this? |
|
@rhuanjl Yes - please do. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6338
This PR aligns the Object constructor with the spec. The previous implementation was treating
args[1]as a new object and setting its prototype.