Disable inlining for x86 when there is try #3993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
force-pushed
the
fix86inline
branch
from
6320c64 to
4773508
Compare
|
Curious- what is the motivation behind this change? |
Cellule
approved these changes
Oct 18, 2017
|
#3832 - enabled inlining into functions with try. On x86, additional analysis is needed to compute arg offsets and stack offsets when there is a bailout in EH region, due to x86 specific calling conventions. Disabling till all corner cases are fixed. |
meg-gupta
force-pushed
the
fix86inline
branch
from
4773508 to
407b8d5
Compare
chakrabot
pushed a commit
that referenced
this pull request
Oct 18, 2017
Merge pull request #3993 from meg-gupta:fix86inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.