feat: deposit channel based account creation #6170

MxmUrw · 2025-10-16T11:52:41Z

Pull Request

Closes: PRO-xxx

Checklist

Please conduct a thorough self-review before opening the PR.

I am confident that the code works.
I have written sufficient tests.
I have written and tested required migrations.
I have updated documentation where appropriate.

Summary

Please include a succinct description of the purpose and content of the PR. What problem does it solve, and how? Link issues, discussions, other PRs, and anything else that will help the reviewer.

coderabbitai · 2025-10-16T11:55:48Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/PRO-2551/deposit-channel-based-account-creation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

dandanlen · 2025-10-16T12:15:52Z

state-chain/pallets/cf-swapping/src/lib.rs

+			// TODO, how to do this?
+			// ensure!(T::SafeMode::get().deposit_enabled, Error::<T>::LiquidityDepositDisabled);


We can add a dedicated safe mode entry for this.

dandanlen · 2025-10-16T12:16:46Z

state-chain/pallets/cf-swapping/src/lib.rs

+
+			// TODO: verify the user signature
+			let target_account_id =
+				external_account.signer_account_id::<cf_primitives::AccountId>();


This should now be possible using the tools merged to main recently in #6141

The user should submit their public key and a signature over some fixed message like "Chainflip::AccountOpen". Then we verify the sig before continuing.

dandanlen · 2025-10-16T12:21:45Z

state-chain/pallets/cf-swapping/src/lib.rs

+		// TODO: This is now duplicated between pallet-cf-lp and pallet-cf-swapping
+		LiquidityDepositAddressReady {


We should name this differently (AccountCreationDepositAddressReady or something).

dandanlen · 2025-10-16T12:25:42Z

state-chain/pallets/cf-swapping/src/lib.rs

 							},
+							SwapOutputAction::CreditFlipAndTransferToGateway {
+								account_id,
+								role_to_register,


Re. the role - I hadn't thought much about this, but I think it makes sense to assume that the 'role' will always be LiquidityProvider (ie. this is for opening LP trade/lending accounts), at least for now.

dandanlen · 2025-10-16T12:40:41Z

state-chain/pallets/cf-swapping/src/lib.rs

+										FundingSource::Swap { swap_request_id },
+									)
+
+									// TODO: transfer funds to gateway


It would be nice if we can piggy-back on the burn_network_fee method in emissions/lib.rs, ie. we accumulate the amount that we want to send to the SC gateway, and then allow the emissions pallet to adjust the transfer amount when it does the burn. Otherwise it's likely that the transaction cost will outweigh the FLIP transferred...

Yeah, the code that does the "burn and transfer" is in the on_initialize() in the emissions lib. To make it work we'll have to keep track of the amount of FLIP to be transferred to the statechain gateway separately from the amount of FLIP to be burned.

Then in the on_initialize() we burn only the amount to be burned, but then transfer (to_be_burned + to_be_transferred).

dandanlen · 2025-10-16T13:03:10Z

state-chain/pallets/cf-ingress-egress/src/lib.rs

+			ChannelAction::LiquidityProvision { lp_account, additional_action, .. } => {
 				T::Balance::credit_account(&lp_account, asset.into(), amount_after_fees.into());
+
+				// TODO execute additional_action


When we dispatch the account creation action (ie. when we receive the deposit into the channel), we want to:

Estimate the swap input amount for 5 FLIP (or whatever our MIN_FUNDING is in the funding pallet)

Take this off the actual deposit amount (like we do for ingress fees)

Initiate a swap into FLIP with this much of the input

Credit the target account with 0.01 FLIP: this should be enough to get started, pending completion of the swap.

When the swap completes, credit the target account with the net amount (ie. swap_output_amount - 0.01 FLIP).

msgmaxim · 2025-10-21T00:46:57Z

state-chain/pallets/cf-emissions/src/lib.rs

 			Ok(ScheduledEgressDetails { egress_id, egress_amount, .. }) => {
-				T::Issuance::burn_offchain(egress_amount.into());
-				Self::deposit_event(Event::NetworkFeeBurned { amount: egress_amount, egress_id });
+				T::Issuance::burn_offchain(egress_amount.saturating_sub(flip_to_be_sent_to_gateway).into());


nit: can deduplicate

Suggested change

T::Issuance::burn_offchain(egress_amount.saturating_sub(flip_to_be_sent_to_gateway).into());

let flip_to_burn = egress_amount.saturating_sub(flip_to_be_sent_to_gateway);

T::Issuance::burn_offchain(flip_to_burn.into());

Self::deposit_event(Event::NetworkFeeBurned { amount: flip_to_burn, egress_id });

msgmaxim · 2025-10-21T01:17:47Z

state-chain/pallets/cf-ingress-egress/src/lib.rs

+						T::FundAccount::fund_account(
+							lp_account.clone(),
+							None,
+							100_000_000_000_000_000u128.into(),


nit: can use FLIPPERINOS_PER_FLIP / 10 here. Also, I see that the same value is being used below. Should this be turned into a constant?

msgmaxim · 2025-10-21T01:22:11Z

state-chain/pallets/cf-ingress-egress/src/lib.rs

+							BoundedVec::new(),		
+							None,
+							None,
+							origin.into(), //maybe change it to internal/OnChainAccount?


I agree, SwapOrigin::Internal makes more sense to me.

msgmaxim · 2025-10-21T01:39:22Z

state-chain/pallets/cf-swapping/src/lib.rs

 							SwapOutputAction::CreditLendingPool { swap_type } => {
 								log_or_panic!("Unexpected refund of a loan swap: {swap_type:?}");
 							},
+							//TODO: Not sure this is even possible we won't do a DCA swap to get the few flip necessary to fund an account


Yeah, this shouldn't be possible. However, If we want to keep this code just in case, I would deduplicate this with the code below that covers successful execution.

msgmaxim · 2025-10-21T01:46:19Z

state-chain/pallets/cf-swapping/src/lib.rs

 										account_id.clone(),
 										None,
-										dca_state.accumulated_output_amount,
+										dca_state.accumulated_output_amount.saturating_sub(100_000_000_000_000_000).into(),


What if the output amount is smaller than 100_000_000_000_000_000, won't this be an accounting problem?

To avoid this scenario (and also the one where the estimation of the required_input fails), we will submit a MIN_PRICE in the extrinsic such that we can be sure to always trigger the swap and obtain as output enough FLIP to cover the initial funding.

albert-llimos · 2025-10-21T12:29:04Z

state-chain/pallets/cf-swapping/src/lib.rs

+			// TODO: Use proper error -> do we want to check this?
+			// ensure!(T::AccountRoleRegistry::is_unregistered(target_account_id), Error::<T>::);


I think I would not enforce this. It might be useful in the future to allow for FLIP topups as part of ingressing assets.

MxmUrw force-pushed the feat/PRO-2551/deposit-channel-based-account-creation branch from b694786 to 3576fa6 Compare October 16, 2025 12:06

dandanlen reviewed Oct 16, 2025

View reviewed changes

msgmaxim reviewed Oct 21, 2025

View reviewed changes

albert-llimos reviewed Oct 21, 2025

View reviewed changes

MxmUrw and others added 12 commits October 22, 2025 17:07

wip: trying to add channel account creation.

95a0d18

wip: adding funding.

57ae528

perform initial funding

75ef0b7

initial flow implemented

5841555

use correct SignatureData

eb1fae1

move to lp pallet

0879cfa

use const INITIAL_FLIP_FUNDING

8affc2b

default to ~10$ worth if estimation fails

0afcae9

handle possible deficit

1e41ef8

register refund address

bf757b6

make role optional + renaming

95a162d

delete comment

6840d06

marcellorigotti force-pushed the feat/PRO-2551/deposit-channel-based-account-creation branch from 874c0ad to 6840d06 Compare October 22, 2025 15:07

		// TODO, how to do this?
		// ensure!(T::SafeMode::get().deposit_enabled, Error::<T>::LiquidityDepositDisabled);

		// TODO: This is now duplicated between pallet-cf-lp and pallet-cf-swapping
		LiquidityDepositAddressReady {

-				T::Issuance::burn_offchain(egress_amount.saturating_sub(flip_to_be_sent_to_gateway).into());
+    let flip_to_burn = egress_amount.saturating_sub(flip_to_be_sent_to_gateway);
+	 T::Issuance::burn_offchain(flip_to_burn.into());
+	 Self::deposit_event(Event::NetworkFeeBurned { amount: flip_to_burn, egress_id });

		// TODO: Use proper error -> do we want to check this?
		// ensure!(T::AccountRoleRegistry::is_unregistered(target_account_id), Error::<T>::);

feat: deposit channel based account creation #6170

Are you sure you want to change the base?

feat: deposit channel based account creation #6170

Conversation

MxmUrw commented Oct 16, 2025

Pull Request

Checklist

Summary

Uh oh!

coderabbitai bot commented Oct 16, 2025

Review skipped

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

msgmaxim Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

msgmaxim Oct 21, 2025 •

edited

Loading