Convert hex string to NSData for device token. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@plonkus awesome!! thanks so much for fixing this. We weren't able to get the push notifications working but couldn't tell where the issue was. I'll merge this, and get it in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
registerWithTokenmethod doesn't correctly convert the device token (inputed as a hexNSString) to anNSDataobject. This causes Twilio to report that the APNs token has an invalid format and push notifications don't go through. See: https://www.twilio.com/docs/api/errors/52134With this change, I convert convert the hex
NSStringto anNSDataobject before passing it to the Twilio SDK and am able to successfully receive push notifications.Thanks for creating this bridge!